Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: batch processor, aligning with latest spec changes for environments variables #1918

Merged
merged 5 commits into from
Feb 14, 2021
Merged

chore: batch processor, aligning with latest spec changes for environments variables #1918

merged 5 commits into from
Feb 14, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Feb 9, 2021

Which problem is this PR solving?

Short description of the changes

  • aligning the latest environment variables and config (names & defaults)
  • changing the logic it works to handle correctly cases like dropping spans when limit is reached, batch size, time to export, schedule time for next export etc.

@obecny obecny added the enhancement New feature or request label Feb 9, 2021
@obecny obecny self-assigned this Feb 9, 2021
@dyladan
Copy link
Member

dyladan commented Feb 9, 2021

The name of the PR is not a great description of the changes. Since it is how the changelog is generated I think we should have descriptive names.

@obecny obecny changed the title chore: fixes for batch processor, environments variables and the way it works chore: batch processor, aligning with latest spec changes for environments variables Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

Merging #1918 (ad33d65) into main (06c7ec7) will decrease coverage by 0.27%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
- Coverage   92.78%   92.51%   -0.28%     
==========================================
  Files         182      178       -4     
  Lines        6366     6063     -303     
  Branches     1342     1291      -51     
==========================================
- Hits         5907     5609     -298     
+ Misses        459      454       -5
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 90.00% <ø> (ø)
...telemetry-tracing/src/export/BatchSpanProcessor.ts 91.20% <93.61%> (+0.29%) ⬆️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...mentation-xml-http-request/src/enums/EventNames.ts

@vmarchaud vmarchaud merged commit 9f965b0 into open-telemetry:main Feb 14, 2021
@obecny obecny deleted the batch-processor branch June 3, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSNev MSNev MSNev approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

@Flarna Flarna Awaiting requested review from Flarna

@johnbley johnbley Awaiting requested review from johnbley

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees

@obecny obecny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchProcessor
4 participants
@obecny @dyladan @vmarchaud @MSNev